Skip to content
Snippets Groups Projects
  1. Sep 18, 2019
    • Neta Zmora's avatar
      image_classifier.py – remove unused cmd-line argument · 7f78b22e
      Neta Zmora authored
      ../../../distiller/apputils/image_classifier.py – remove unused
      `--extras` command-line argument
      7f78b22e
    • Neta Zmora's avatar
      Merge nzmora's local changes · 5532eb90
      Neta Zmora authored
      Odds and ends commit
      5532eb90
    • Neta Zmora's avatar
      Odds and ends commit · 8d55ab15
      Neta Zmora authored
      A bundle of very small, and mostly non-functional, changes to the code.
      Mostly they are unrelated to each other
      ../../../distiller/apputils/checkpoint.py – add info to exception
      
      ../../../distiller/apputils/image_classifier.py – remove unused
      `--extras` command-line argument
      
      ../../../distiller/thinning.py – code refactoring (non-functional)
      except for adding a new public API: contract_model()
      
      ../../classifier_compression/compress_classifier.py – use
      contract_model() when using `--thinnify`
      
      ../../lottery_ticket/README.md – remove illegal characters in
      the text
      8d55ab15
  2. Sep 10, 2019
  3. Sep 09, 2019
  4. Sep 08, 2019
  5. Sep 06, 2019
  6. Sep 05, 2019
  7. Sep 04, 2019
  8. Sep 02, 2019
  9. Sep 01, 2019
    • Neta Zmora's avatar
      Merge AMC Linear layer support · 2f3a9ac1
      Neta Zmora authored
      2f3a9ac1
    • Neta Zmora's avatar
      AMC: add pruning of FC layers · 3f7a9408
      Neta Zmora authored
      FMReconstructionChannelPruner: add support for nn.Linear layers
      utils.py: add non_zero_channels()
      thinning: support removing channels from FC layers preceding Conv layers
      test_pruning.py: add test_row_pruning()
      scheduler: init from a dictionary of Maskers
      coach_if.py – fix imports of Clipped-PPO and TD3
      3f7a9408
  10. Aug 29, 2019
  11. Aug 28, 2019
  12. Aug 27, 2019
  13. Aug 26, 2019
  14. Aug 24, 2019
  15. Aug 23, 2019
    • Neta Zmora's avatar
      ranked_structures_pruner.py issue #363 · 61fab0d0
      Neta Zmora authored
      When adding support for specifying the rounding function for pruning structures, the code of `ActivationRankedFilterPruner` was updated incorrectly (adding an extra argument).
      This code is not covered by any of the tests and therefore the bug was not caught in time.  To do: add unit test.
      Unverified
      61fab0d0
  16. Aug 22, 2019
    • Neta Zmora's avatar
      Add NCF example (#350) · 6e223f85
      Neta Zmora authored
      * NCF scripts with Distiller integration
      
      This NCF implementation is based on the implementation found in the MLPerf
      Training GitHub repository, specifically on the last revision of the code
      before the switch to the extended dataset. See:
      https://github.com/mlperf/training/tree/fe17e837ed12974d15c86d5173fe8f2c188434d5/recommendation/pytorch
      
      We've made several modifications to the code:
      * Removed all MLPerf specific code including logging
      * In ncf.py:
        * Added calls to Distiller compression APIs
        * Added progress indication in training and evaluation flows
      * In neumf.py:
        * Added option to split final FC layer
        * Replaced all functional calls with modules so they can be detected
          by Distiller
      * In dataset.py:
        * Speed up data loading - On first data will is loaded from CSVs and
          then pickled. On subsequent runs the pickle is loaded. This is much
          faster than the original implementation, but still very slow.
        * Added progress indication during data load process
      * Removed some irrelevant content from README.md
      
      * ncf.py - fix wrong nb_users/items
      
      * NCF changes to make it compatible with latest changes in master
      
      * Pass the 'sigmoid' flag in NeuMF.forward as a bool tensor instead of
        a simple boolean. Required to make the model traceable (it?d be better
        to not have it an argument of forward at all, but keeping changes to
        a minimum)
      * Call prepare_model with dummy_input
      
      * Cleanup code, update reqs, add stats files, add details to README
      
      * Update NCF README.md
      
      * Remove debug comments
      
      * Remove unnecessary script + NCF QAT scheduler (for now)
      Unverified
      6e223f85
    • Neta Zmora's avatar
      apputils/checkpoint.py: load_checkpoint can be called w/o specifying the model · b41c4d2d
      Neta Zmora authored
      This is inspired by @barrh’s PR https://github.com/NervanaSystems/distiller/pull/246
      but it at a “slower-integration-pace” and w/o changing APIs.
      
      1. create_model() attaches model attributes (arch, dataset, is_parallel) to created models.
      2. save_checkpoint() stores the new model attributes with checkpoint metadata
      3. load_checkpoint() can be invoked with model=None, in which case we attempt
      to create the model from the stored checkpoint metadata.
      b41c4d2d
    • Neta Zmora's avatar
      checkpoint.py: non-functional code refactoring · 99124355
      Neta Zmora authored
      Rearranged the code for easier reading and maintenance
      99124355
    • Neta Zmora's avatar
      create_model: fix bug when trying to use an unsupported dataset · bdafebea
      Neta Zmora authored
      When trying to create a model using an unsupported dataset, create_model()
      should raise a ValueError, but didn't.
      One of the unit-tests (test_create_model_cifar in test_infra.py) was
      designed to test this condition (creating a model using an unsupported
      dataset - cifar100 in this case), but due to DataParallel implementation
      details, the test condition did not function on multi-GPU machines and
      did fail the test.
      Unit tests should also be executed on single-GPU machines for full-coverage.
      bdafebea
  17. Aug 21, 2019
  18. Aug 20, 2019
  19. Aug 19, 2019
Loading