Skip to content
Snippets Groups Projects
  1. Jan 24, 2018
  2. Jun 11, 2017
    • Felix Cheung's avatar
      [SPARK-20877][SPARKR][FOLLOWUP] clean up after test move · 9f4ff955
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      clean up after big test move
      
      ## How was this patch tested?
      
      unit tests, jenkins
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      
      Closes #18267 from felixcheung/rtestset2.
      9f4ff955
    • Felix Cheung's avatar
      [SPARK-20877][SPARKR] refactor tests to basic tests only for CRAN · dc4c3518
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      Move all existing tests to non-installed directory so that it will never run by installing SparkR package
      
      For a follow-up PR:
      - remove all skip_on_cran() calls in tests
      - clean up test timer
      - improve or change basic tests that do run on CRAN (if anyone has suggestion)
      
      It looks like `R CMD build pkg` will still put pkg\tests (ie. the full tests) into the source package but `R CMD INSTALL` on such source package does not install these tests (and so `R CMD check` does not run them)
      
      ## How was this patch tested?
      
      - [x] unit tests, Jenkins
      - [x] AppVeyor
      - [x] make a source package, install it, `R CMD check` it - verify the full tests are not installed or run
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      
      Closes #18264 from felixcheung/rtestset.
      dc4c3518
  3. May 12, 2017
    • Felix Cheung's avatar
      [SPARK-20704][SPARKR] change CRAN test to run single thread · 888b84ab
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      - [x] need to test by running R CMD check --as-cran
      - [x] sanity check vignettes
      
      ## How was this patch tested?
      
      Jenkins
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      
      Closes #17945 from felixcheung/rchangesforpackage.
      888b84ab
  4. May 03, 2017
    • Felix Cheung's avatar
      [SPARK-20543][SPARKR] skip tests when running on CRAN · fc472bdd
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      General rule on skip or not:
      skip if
      - RDD tests
      - tests could run long or complicated (streaming, hivecontext)
      - tests on error conditions
      - tests won't likely change/break
      
      ## How was this patch tested?
      
      unit tests, `R CMD check --as-cran`, `R CMD check`
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      
      Closes #17817 from felixcheung/rskiptest.
      fc472bdd
  5. Jul 17, 2016
    • Felix Cheung's avatar
      [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop · d27fe9ba
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      Fix R SparkSession init/stop, and warnings of reusing existing Spark Context
      
      ## How was this patch tested?
      
      unit tests
      
      shivaram
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      
      Closes #14177 from felixcheung/rsessiontest.
      d27fe9ba
  6. Jun 17, 2016
    • Felix Cheung's avatar
      [SPARK-15159][SPARKR] SparkR SparkSession API · 8c198e24
      Felix Cheung authored
      ## What changes were proposed in this pull request?
      
      This PR introduces the new SparkSession API for SparkR.
      `sparkR.session.getOrCreate()` and `sparkR.session.stop()`
      
      "getOrCreate" is a bit unusual in R but it's important to name this clearly.
      
      SparkR implementation should
      - SparkSession is the main entrypoint (vs SparkContext; due to limited functionality supported with SparkContext in SparkR)
      - SparkSession replaces SQLContext and HiveContext (both a wrapper around SparkSession, and because of API changes, supporting all 3 would be a lot more work)
      - Changes to SparkSession is mostly transparent to users due to SPARK-10903
      - Full backward compatibility is expected - users should be able to initialize everything just in Spark 1.6.1 (`sparkR.init()`), but with deprecation warning
      - Mostly cosmetic changes to parameter list - users should be able to move to `sparkR.session.getOrCreate()` easily
      - An advanced syntax with named parameters (aka varargs aka "...") is supported; that should be closer to the Builder syntax that is in Scala/Python (which unfortunately does not work in R because it will look like this: `enableHiveSupport(config(config(master(appName(builder(), "foo"), "local"), "first", "value"), "next, "value"))`
      - Updating config on an existing SparkSession is supported, the behavior is the same as Python, in which config is applied to both SparkContext and SparkSession
      - Some SparkSession changes are not matched in SparkR, mostly because it would be breaking API change: `catalog` object, `createOrReplaceTempView`
      - Other SQLContext workarounds are replicated in SparkR, eg. `tables`, `tableNames`
      - `sparkR` shell is updated to use the SparkSession entrypoint (`sqlContext` is removed, just like with Scale/Python)
      - All tests are updated to use the SparkSession entrypoint
      - A bug in `read.jdbc` is fixed
      
      TODO
      - [x] Add more tests
      - [ ] Separate PR - update all roxygen2 doc coding example
      - [ ] Separate PR - update SparkR programming guide
      
      ## How was this patch tested?
      
      unit tests, manual tests
      
      shivaram sun-rui rxin
      
      Author: Felix Cheung <felixcheung_m@hotmail.com>
      Author: felixcheung <felixcheung_m@hotmail.com>
      
      Closes #13635 from felixcheung/rsparksession.
      8c198e24
  7. Dec 07, 2015
    • Sun Rui's avatar
      [SPARK-12034][SPARKR] Eliminate warnings in SparkR test cases. · 39d677c8
      Sun Rui authored
      This PR:
      1. Suppress all known warnings.
      2. Cleanup test cases and fix some errors in test cases.
      3. Fix errors in HiveContext related test cases. These test cases are actually not run previously due to a bug of creating TestHiveContext.
      4. Support 'testthat' package version 0.11.0 which prefers that test cases be under 'tests/testthat'
      5. Make sure the default Hadoop file system is local when running test cases.
      6. Turn on warnings into errors.
      
      Author: Sun Rui <rui.sun@intel.com>
      
      Closes #10030 from sun-rui/SPARK-12034.
      39d677c8
  8. Aug 26, 2015
    • Yu ISHIKAWA's avatar
      [MINOR] [SPARKR] Fix some validation problems in SparkR · 773ca037
      Yu ISHIKAWA authored
      Getting rid of some validation problems in SparkR
      https://github.com/apache/spark/pull/7883
      
      cc shivaram
      
      ```
      inst/tests/test_Serde.R:26:1: style: Trailing whitespace is superfluous.
      
      ^~
      inst/tests/test_Serde.R:34:1: style: Trailing whitespace is superfluous.
      
      ^~
      inst/tests/test_Serde.R:37:38: style: Trailing whitespace is superfluous.
        expect_equal(class(x), "character")
                                           ^~
      inst/tests/test_Serde.R:50:1: style: Trailing whitespace is superfluous.
      
      ^~
      inst/tests/test_Serde.R:55:1: style: Trailing whitespace is superfluous.
      
      ^~
      inst/tests/test_Serde.R:60:1: style: Trailing whitespace is superfluous.
      
      ^~
      inst/tests/test_sparkSQL.R:611:1: style: Trailing whitespace is superfluous.
      
      ^~
      R/DataFrame.R:664:1: style: Trailing whitespace is superfluous.
      
      ^~~~~~~~~~~~~~
      R/DataFrame.R:670:55: style: Trailing whitespace is superfluous.
                      df <- data.frame(row.names = 1 : nrow)
                                                            ^~~~~~~~~~~~~~~~
      R/DataFrame.R:672:1: style: Trailing whitespace is superfluous.
      
      ^~~~~~~~~~~~~~
      R/DataFrame.R:686:49: style: Trailing whitespace is superfluous.
                          df[[names[colIndex]]] <- vec
                                                      ^~~~~~~~~~~~~~~~~~
      ```
      
      Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>
      
      Closes #8474 from yu-iskw/minor-fix-sparkr.
      773ca037
  9. Aug 25, 2015
    • Sun Rui's avatar
      [SPARK-10048] [SPARKR] Support arbitrary nested Java array in serde. · 71a138cd
      Sun Rui authored
      This PR:
      1. supports transferring arbitrary nested array from JVM to R side in SerDe;
      2. based on 1, collect() implemenation is improved. Now it can support collecting data of complex types
         from a DataFrame.
      
      Author: Sun Rui <rui.sun@intel.com>
      
      Closes #8276 from sun-rui/SPARK-10048.
      71a138cd
Loading