Remove basic-auth-plugin for CE

This is no longer required as it's built into the CE gateway.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

chart/openfaas/templates/NOTES.txt

@@ -3,6 +3,7 @@ To verify that openfaas has started, run:
   kubectl -n {{ .Release.Namespace }} get deployments -l "release={{ .Release.Name }}, app={{ template "openfaas.name" . }}"
 
 {{- if .Values.generateBasicAuth }}
+
 To retrieve the admin password, run:
 
   echo $(kubectl -n {{ .Release.Namespace }} get secret basic-auth -o jsonpath="{.data.basic-auth-password}" | base64 --decode)

chart/openfaas/templates/basic-auth-plugin-dep.yaml

 {{- $functionNs := default .Release.Namespace .Values.functionNamespace }}
 {{- if .Values.basic_auth }}
+{{- if .Values.openfaasPro }}
 {{- if not .Values.oidcAuthPlugin.enabled }}
 ---
 apiVersion: apps/v1
@@ -104,3 +105,4 @@ spec:
 
 {{- end }}
 {{- end }}
+{{- end }}
\ No newline at end of file

chart/openfaas/templates/gateway-dep.yaml

@@ -164,12 +164,14 @@ spec:
         - name: auth_pass_body
           value: "false"
         {{- else }}
+        {{- if .Values.openfaasPro }}
         - name: auth_proxy_url
           value: "http://basic-auth-plugin.{{ .Release.Namespace }}:8080/validate"
         - name: auth_pass_body
           value: "false"
         {{- end }}
         {{- end }}
+        {{- end }}
         - name: scale_from_zero
           value: "{{ .Values.gateway.scaleFromZero }}"
         - name: max_idle_conns