Skip to content
Snippets Groups Projects
Commit 6ea1a632 authored by Yifan Zhao's avatar Yifan Zhao
Browse files

Made _load inplace for easier inheritance

parent 4c5b8d9b
No related branches found
No related tags found
No related merge requests found
......@@ -291,7 +291,7 @@ class QoSModelP2(IQoSModel):
def _init(self):
if self.storage and self.storage.is_file():
self.qos_df, self.baseline_qos = self._load(self.storage)
self._load(self.storage)
else:
knob_names = [k.name for k in self.app.knobs]
self.qos_df = pd.DataFrame(index=self.app.ops, columns=knob_names)
......@@ -306,11 +306,9 @@ class QoSModelP2(IQoSModel):
self._save(self.storage)
super()._init()
def _load(self, path: Path) -> Tuple[pd.DataFrame, float]:
def _load(self, path: Path):
with path.open() as f:
data = json.load(f)
df = pd.DataFrame(data["df"])
baseline_qos = float(data["bqos"])
if "app_name" in data:
name = data["app_name"]
if self.app.name != name:
......@@ -321,7 +319,8 @@ class QoSModelP2(IQoSModel):
else:
msg_logger.warning("Loaded profile does not have app name identifier")
msg_logger.info(f"Model {self.name} loaded saved model at {path}")
return df, baseline_qos
self.qos_df = pd.DataFrame(data["df"])
self.baseline_qos = float(data["bqos"])
def _save(self, path: Path):
import os
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment