Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
Hercules
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
llvm
Hercules
Merge requests
!78
Fix outlining again
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fix outlining again
outline_fix_2
into
main
Overview
0
Commits
1
Pipelines
1
Changes
1
Merged
rarbore2
requested to merge
outline_fix_2
into
main
4 months ago
Overview
0
Commits
1
Pipelines
1
Changes
1
Expand
Fix not calling convert_id on the data inputs to phi nodes.
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
146db80c
1 commit,
4 months ago
1 file
+
4
−
0
Side-by-side
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
hercules_opt/src/outline.rs
+
4
−
0
Options
@@ -253,6 +253,10 @@ pub fn outline(
@@ -253,6 +253,10 @@ pub fn outline(
if
let
Node
::
Phi
{
control
,
data
}
=
&
mut
node
if
let
Node
::
Phi
{
control
,
data
}
=
&
mut
node
&&
*
control
==
top_node
&&
*
control
==
top_node
{
{
for
datum
in
data
.iter_mut
()
{
*
datum
=
convert_id
(
*
datum
);
}
// If this node is a phi on the top node, we need to replace the
// If this node is a phi on the top node, we need to replace the
// inputs corresponding to outside partition predecessors with a
// inputs corresponding to outside partition predecessors with a
// single data input (with the corresponding control input of
// single data input (with the corresponding control input of
Loading