Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
Hercules
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
llvm
Hercules
Merge requests
!72
Fix 'Branch' not being a terminator with 'is_terminator'
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fix 'Branch' not being a terminator with 'is_terminator'
fix_sched
into
main
Overview
0
Commits
1
Pipelines
1
Changes
1
Merged
rarbore2
requested to merge
fix_sched
into
main
4 months ago
Overview
0
Commits
1
Pipelines
1
Changes
1
Expand
'Branch' schedule IR inst was incorrectly called not a terminator. This was causing branch instructions to float up in emitted LLVM, which isn't allowed.
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
bce54c4c
1 commit,
4 months ago
1 file
+
14
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
hercules_cg/src/sched_ir.rs
+
14
−
1
Options
@@ -412,6 +412,19 @@ impl SInst {
}
}
pub
fn
is_branch
(
&
self
)
->
bool
{
if
let
SInst
::
Branch
{
cond
:
_
,
false_target
:
_
,
true_target
:
_
,
}
=
self
{
true
}
else
{
false
}
}
pub
fn
is_partition_exit
(
&
self
)
->
bool
{
if
let
SInst
::
PartitionExit
{
data_outputs
:
_
}
=
self
{
true
@@ -429,7 +442,7 @@ impl SInst {
}
pub
fn
is_terminator
(
&
self
)
->
bool
{
self
.is_jump
()
||
self
.is_partition_exit
()
||
self
.is_return
()
self
.is_jump
()
||
self
.is_branch
()
||
self
.is_partition_exit
()
||
self
.is_return
()
}
pub
fn
try_thread_id
(
&
self
)
->
Option
<
(
usize
,
ForkJoinID
)
>
{
Loading