Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
Hercules
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
llvm
Hercules
Merge requests
!65
Fix creation of intermediate DC IDs in inline substitution
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fix creation of intermediate DC IDs in inline substitution
fix_inline_dc_sub_2
into
main
Overview
0
Commits
1
Pipelines
1
Changes
1
Merged
rarbore2
requested to merge
fix_inline_dc_sub_2
into
main
8 months ago
Overview
0
Commits
1
Pipelines
1
Changes
1
Expand
Fix the non-sense DC IDs that get generated when substituting dynamic constants in inlining
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
b6740f03
1 commit,
8 months ago
1 file
+
3
−
3
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
hercules_opt/src/inline.rs
+
3
−
3
Options
@@ -216,8 +216,8 @@ fn inline_func(
// as the new references we just made in the first step. We
// actually want to institute all the updates
// *simultaneously*, hence the two step maneuver.
let
num
_dc
s
=
edit
.num_dynamic_constants
();
for
(
dc_a
,
dc_n
)
in
zip
(
dcs_a
,
num
_dc
s
..
)
{
let
first
_dc
=
edit
.num_dynamic_constants
()
+
1
;
for
(
dc_a
,
dc_n
)
in
zip
(
dcs_a
,
first
_dc
..
)
{
substitute_dynamic_constants_in_node
(
*
dc_a
,
DynamicConstantID
::
new
(
dc_n
),
@@ -225,7 +225,7 @@ fn inline_func(
&
mut
edit
,
);
}
for
(
dc_n
,
dc_b
)
in
zip
(
num
_dc
s
..
,
dcs_b
.iter
())
{
for
(
dc_n
,
dc_b
)
in
zip
(
first
_dc
..
,
dcs_b
.iter
())
{
substitute_dynamic_constants_in_node
(
DynamicConstantID
::
new
(
dc_n
),
*
dc_b
,
Loading