Fix schedule gen to panic only if non-root array types/constants are used
Merged
Fix schedule gen to panic only if non-root array types/constants are used
codegen-used-types
into
main
1 unresolved thread
1 unresolved thread
My solution is to change the lists of schedule types and constants to be lists of options, and then in the conversion functions we produce None
for types/constants with non-root arrays.
This means we don't actually have to determine all of the used types/constants ahead of time and we can just panic when we try to use an invalid type or constant.
With this fix, Juno matmul can build and run.
Merge request reports
Activity
requested review from @rarbore2
assigned to @aaronjc4
91 break; 92 } else { 93 match &stypes[id.idx()] { 94 None => { 95 res_none = true; 96 break; 97 } 98 Some(t) => typs.push(t.clone()), 99 } 100 } 101 } 102 if res_none { 103 None 104 } else { 105 Some(SType::Product(typs.into())) 106 } mentioned in commit f4159073
Please register or sign in to reply