Skip to content
Snippets Groups Projects

Fix schedule gen to panic only if non-root array types/constants are used

Merged Fix schedule gen to panic only if non-root array types/constants are used
codegen-used-types into main
1 unresolved thread
Merged Aaron Councilman requested to merge codegen-used-types into main
1 unresolved thread

My solution is to change the lists of schedule types and constants to be lists of options, and then in the conversion functions we produce None for types/constants with non-root arrays. This means we don't actually have to determine all of the used types/constants ahead of time and we can just panic when we try to use an invalid type or constant.

With this fix, Juno matmul can build and run.

Merge request reports

Pipeline #200343 passed

Stage: build
Stage: test

Pipeline passed for a51f99ef on codegen-used-types

Approved by
rarbore2

Merged by rarbore2rarbore2 8 months ago (Nov 23, 2024 6:49am UTC)

Merge details

  • Changes merged into main with f4159073 (commits were squashed).
  • Deleted the source branch.

Pipeline #200349 passed

Stage: build
Stage: test

Pipeline passed for f4159073 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
hercules_cg/src/sched_gen.rs
91 break;
92 } else {
93 match &stypes[id.idx()] {
94 None => {
95 res_none = true;
96 break;
97 }
98 Some(t) => typs.push(t.clone()),
99 }
100 }
101 }
102 if res_none {
103 None
104 } else {
105 Some(SType::Product(typs.into()))
106 }
  • rarbore2 approved this merge request

    approved this merge request

  • rarbore2
    rarbore2 @rarbore2 ·
    Maintainer

    Really exciting that we can build Juno matmul finally!

  • rarbore2 mentioned in commit f4159073

    mentioned in commit f4159073

  • rarbore2 merged

    merged

    • Please register or sign in to reply