Skip to content
Snippets Groups Projects

Add (dynamic) constants and types to editor

Merged Add (dynamic) constants and types to editor
ryanjz2/hercules-onnx:editor-types-constants into main
All threads resolved!
Merged Ryan Ziegler requested to merge ryanjz2/hercules-onnx:editor-types-constants into main
All threads resolved!

Adds support for editor to mutate global constants and types in a safe manner. This assumes no simultaneous calls to .edit will occur across any editors. Type ID deduplication is done by a linear scan for now, although we could of course switch this in the future. I've tested this and confirmed it does work properly for return modification in interprocedural SROA.

Edited by Ryan Ziegler

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • rarbore2
  • rarbore2
  • rarbore2
  • rarbore2
  • rarbore2
    rarbore2 @rarbore2 ·
    Maintainer

    Overall LGTM. Good code quality, and the actual editor impl itself is pretty clean.

    Edited by rarbore2
  • rarbore2 assigned to @rarbore2

    assigned to @rarbore2

  • rarbore2 assigned to @ryanjz2 and unassigned @rarbore2

    assigned to @ryanjz2 and unassigned @rarbore2

  • rarbore2 requested review from @rarbore2

    requested review from @rarbore2

  • Ryan Ziegler added 1 commit

    added 1 commit

    Compare with previous version

  • Ryan Ziegler added 1 commit

    added 1 commit

    Compare with previous version

  • Ryan Ziegler added 1 commit

    added 1 commit

    Compare with previous version

  • Ryan Ziegler resolved all threads

    resolved all threads

  • rarbore2 approved this merge request

    approved this merge request

  • rarbore2 merged

    merged

  • rarbore2 mentioned in commit d5d8601e

    mentioned in commit d5d8601e

    • Please register or sign in to reply