Add intrinsic calls to Hercules IR (!31) · Merge requests · llvm / Hercules · GitLab

Snippets Groups Projects

Merged Aaron Councilman requested to merge hercules-intrinsics into main 7 months ago

2 unresolved threads

Add new intrinsic node (with parsing and dumping)
Add type checking and constant propagation rules for intrinsics

Activity

Aaron Councilman requested review from @rarbore2 7 months ago

requested review from @rarbore2
Aaron Councilman @aaronjc4 · 7 months ago

Author Owner

We should probably actually create a good set of intrinsics before merging, rather than just sqrt. Any thoughts?

Edited 7 months ago by Aaron Councilman
rarbore2 approved this merge request 7 months ago

approved this merge request
rarbore2 @rarbore2 · 7 months ago

Maintainer
IR definition LGTM. Here's a list maybe?

sqrt

abs

exp / pow

trig
Aaron Councilman added 6 commits 7 months ago
added 6 commits

345cdd59...bf1b9c90 - 2 commits from branch main

371204c3 - Start adding more intrinsics

a43b5014 - Merge branch 'juno-fix' into hercules-intrinsics

fba27e75 - Finish CCP for intrinsics

fbdfe02e - Merge branch 'main' into hercules-intrinsics

Compare with previous version
Toggle commit list
Aaron Councilman @aaronjc4 · 7 months ago

Author Owner
I added stuff based on what I found in Rust and things that I think are pretty common:

abs

trig (sin/cos/tan, asin/acos/atan, sinh/cosh/tanh, asinh/acosh/atanh, atan2)

sqrt and cbrt (cube root)

floor and ceil

exponents, powers, logs
Aaron Councilman marked this merge request as ready 7 months ago

marked this merge request as ready
rarbore2 @rarbore2 started a thread on an old version of the diff 7 months ago

hercules_ir/src/ir.rs

 pub enum Intrinsic {
     Abs,
     ACos,
     ACosh,
     ASin,
     ASinh,
     ATan,
     ATan2,
     ATanh,
     Cbrt,  // Cube root
     Ceil,
     Cos,
     Cosh,
     Exp,   // e^x
     Exp2,  // 2^x
     ExpM1, // e^x - 1

rarbore2 @rarbore2 · 7 months ago

Maintainer

Also CCP is nuts could we maybe make a macro to abstract some of this out?
Aaron Councilman @aaronjc4 · 7 months ago

Author Owner

Yeah, that's a good idea. I'll work on that.
Aaron Councilman @aaronjc4 · 7 months ago

Author Owner

I've added macros that handle the unary and binary float intrinsics (the most common cases). There are still 3 that are large expressions but these are all unique and would be harder to generalize into a nice macro
rarbore2 @rarbore2 · 7 months ago

Maintainer

LGTM. What's up with ExpM1? Is this a common primitive that's supported / expected?
Aaron Councilman @aaronjc4 · 7 months ago

Author Owner

From Rust docs: "Returns e^(self) - 1 in a way that is accurate even if the number is close to zero." Presumably if e^x is very little over 1 we would lose too much precision representing e^x and then subtracting 1. I've definitely seen it before, e^x - 1 is not uncommon in math
rarbore2 @rarbore2 · 7 months ago

Maintainer

Ah.
Please register or sign in to reply

Aaron Councilman added 1 commit 7 months ago

added 1 commit

0b3fae7b - Clean-up CCP with macros

Compare with previous version

Aaron Councilman added 1 commit 7 months ago

added 1 commit

0011147f - Clean-up CCP more

Compare with previous version

Aaron Councilman added 2 commits 7 months ago

added 2 commits

1cc22fd8 - Clean-up IR defs
3618b7ce - Rename ln_p1 to ln_1p to match Rust

Compare with previous version

rarbore2 mentioned in commit 7 months ago

mentioned in commit 5e26d102

rarbore2 merged 7 months ago

merged

Please register or sign in to reply