Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
Hercules
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
llvm
Hercules
Merge requests
!225
BFS optimization
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
BFS optimization
more_opts9
into
main
Overview
0
Commits
2
Pipelines
2
Changes
3
Merged
rarbore2
requested to merge
more_opts9
into
main
2 weeks ago
Overview
0
Commits
2
Pipelines
2
Changes
3
Expand
Add pass to optimize stores in BFS.
0
0
Merge request reports
Viewing commit
00154685
Prev
Next
Show latest version
3 files
+
128
−
2
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
3
Search (e.g. *.vue) (Ctrl+P)
00154685
make bfs faster on cpu
· 00154685
rarbore2
authored
2 weeks ago
hercules_opt/src/fork_transforms.rs
+
119
−
0
Options
@@ -1515,6 +1515,10 @@ fn fork_fusion(
* Looks for would-be monoid reduces, if not for a gate on the reduction.
* Partially predicate the gated reduction to allow for a proper monoid
* reduction.
*
* Looks for monoid reduces that occur through a gated write to a single
* location, and lift them to a proper monoid reduction with a single gated
* write afterwards.
*/
pub
fn
clean_monoid_reduces
(
editor
:
&
mut
FunctionEditor
,
typing
:
&
Vec
<
TypeID
>
)
{
for
id
in
editor
.node_ids
()
{
@@ -1676,6 +1680,121 @@ pub fn clean_monoid_reduces(editor: &mut FunctionEditor, typing: &Vec<TypeID>) {
});
}
}
for
id
in
editor
.node_ids
()
{
// Identify reduce/write/phi cycle through which a sparse AND reduction
// is occurring.
let
nodes
=
&
editor
.func
()
.nodes
;
let
Some
((
join
,
init
,
reduct
))
=
nodes
[
id
.idx
()]
.try_reduce
()
else
{
continue
;
};
let
join_pred
=
nodes
[
join
.idx
()]
.try_join
()
.unwrap
();
let
join_succ
=
editor
.get_users
(
join
)
.filter
(|
id
|
nodes
[
id
.idx
()]
.is_control
())
.next
()
.unwrap
();
let
Some
((
_
,
phi_data
))
=
nodes
[
reduct
.idx
()]
.try_phi
()
else
{
continue
;
};
if
phi_data
.len
()
!=
2
{
continue
;
}
let
phi_other_use
=
if
phi_data
[
0
]
==
id
{
phi_data
[
1
]
}
else
if
phi_data
[
1
]
==
id
{
phi_data
[
0
]
}
else
{
continue
;
};
let
Some
((
collect
,
data
,
indices
))
=
nodes
[
phi_other_use
.idx
()]
.try_write
()
else
{
continue
;
};
if
collect
!=
id
{
continue
;
}
if
indices
.into_iter
()
.any
(|
idx
|
idx
.is_position
())
{
continue
;
}
if
!
is_false
(
editor
,
data
)
{
continue
;
}
let
Some
(
preds
)
=
nodes
[
join_pred
.idx
()]
.try_region
()
else
{
continue
;
};
if
preds
.len
()
!=
2
{
continue
;
}
let
Some
((
if1
,
_
))
=
nodes
[
preds
[
0
]
.idx
()]
.try_control_proj
()
else
{
continue
;
};
let
Some
((
if2
,
sel
))
=
nodes
[
preds
[
1
]
.idx
()]
.try_control_proj
()
else
{
continue
;
};
if
if1
!=
if2
{
continue
;
}
let
Some
((
_
,
mut
cond
))
=
nodes
[
if1
.idx
()]
.try_if
()
else
{
continue
;
};
// Transform to a monoid reduction and a single gated write.
let
negated
=
phi_other_use
==
phi_data
[
sel
];
let
indices
=
indices
.to_vec
()
.into_boxed_slice
();
editor
.edit
(|
mut
edit
|
{
let
t
=
edit
.add_constant
(
Constant
::
Boolean
(
true
));
let
t
=
edit
.add_node
(
Node
::
Constant
{
id
:
t
});
let
f
=
edit
.add_constant
(
Constant
::
Boolean
(
false
));
let
f
=
edit
.add_node
(
Node
::
Constant
{
id
:
f
});
if
negated
{
cond
=
edit
.add_node
(
Node
::
Unary
{
op
:
UnaryOperator
::
Not
,
input
:
cond
,
});
}
let
reduce_id
=
NodeID
::
new
(
edit
.num_node_ids
());
let
and_id
=
NodeID
::
new
(
edit
.num_node_ids
()
+
1
);
edit
.add_node
(
Node
::
Reduce
{
control
:
join
,
init
:
t
,
reduct
:
and_id
,
});
edit
.add_node
(
Node
::
Binary
{
op
:
BinaryOperator
::
And
,
left
:
cond
,
right
:
reduce_id
,
});
let
new_if
=
edit
.add_node
(
Node
::
If
{
control
:
join
,
cond
:
reduce_id
,
});
let
cpj1
=
edit
.add_node
(
Node
::
ControlProjection
{
control
:
new_if
,
selection
:
0
,
});
let
cpj2
=
edit
.add_node
(
Node
::
ControlProjection
{
control
:
new_if
,
selection
:
1
,
});
let
region
=
edit
.add_node
(
Node
::
Region
{
preds
:
Box
::
new
([
cpj1
,
cpj2
]),
});
let
write
=
edit
.add_node
(
Node
::
Write
{
collect
:
init
,
data
:
f
,
indices
,
});
let
phi
=
edit
.add_node
(
Node
::
Phi
{
control
:
region
,
data
:
Box
::
new
([
write
,
init
]),
});
edit
=
edit
.replace_all_uses_where
(
id
,
phi
,
|
other_id
|
{
*
other_id
!=
phi_other_use
&&
*
other_id
!=
reduct
})
?
;
edit
.replace_all_uses_where
(
join
,
region
,
|
id
|
*
id
==
join_succ
)
});
}
}
/*
Loading