Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
Hercules
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
llvm
Hercules
Merge requests
!188
Loop canon bound fix
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Loop canon bound fix
loop-canon-bound-fix
into
main
Overview
0
Commits
4
Pipelines
2
Changes
3
Merged
Xavier Routh
requested to merge
loop-canon-bound-fix
into
main
1 month ago
Overview
0
Commits
4
Pipelines
2
Changes
3
Expand
0
0
Merge request reports
Viewing commit
07921708
Prev
Next
Show latest version
3 files
+
17
−
17
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
3
Search (e.g. *.vue) (Ctrl+P)
07921708
loop canon bound fix
· 07921708
Xavier Routh
authored
1 month ago
hercules_opt/src/loop_bound_canon.rs
+
14
−
10
Options
@@ -270,17 +270,20 @@ pub fn canonicalize_single_loop_bounds(
edit
.replace_all_uses_where
(
bound_id
,
new_condition
,
|
usee
|
*
usee
==
binop_node
)
?
;
}
// Add back to uses of the IV
for
user
in
update_expr_users
{
let
new_user
=
Node
::
Binary
{
left
:
user
,
right
:
*
initializer
,
op
:
BinaryOperator
::
Add
,
};
let
new_user
=
edit
.add_node
(
new_user
);
edit
=
edit
.replace_all_uses
(
user
,
new_user
)
?
;
}
// for user in update_expr_users {
// let new_user = Node::Binary {
// left: user,
// right: *initializer,
// op: BinaryOperator::Add,
// };
// let new_user = edit.add_node(new_user);
// edit = edit.replace_all_uses(user, new_user)?;
// }
// for
// Add the offset back to users of the IV update expression
let
new_user
=
Node
::
Binary
{
left
:
*
update_expression
,
right
:
*
initializer
,
@@ -294,6 +297,7 @@ pub fn canonicalize_single_loop_bounds(
&&
*
usee
!=
condition_node
})
?
;
// Add the offset back to users of the IV directly
let
new_user
=
Node
::
Binary
{
left
:
*
iv_phi
,
right
:
*
initializer
,
Loading