Fix GPU addressing bug
While working on BFS discovered a bug in the address computations for the GPU backend when dealing with arrays of products.
Discovered a few issues that were causing this
- The size of the element type of an array was not being put in parentheses leading to very weird computations
- Offsets into a record were not being computed correctly (there was an unnecessary subtraction)
- Offsets into a record were not being generated in code
- When processing indices the type of the current collection was not being updated which is necessary to properly compute sizes
- (Actually unrelated, but noticed it) Sizes of arrays were not being computed properly, it was using
get_alignment
as the element size rather thanget_size
.
See comments for some questions I have related to extra_dim_collects
.
Merge request reports
Activity
Please register or sign in to reply