Skip to content

Fix GPU addressing bug

Aaron Councilman requested to merge gpu-addressing-bug into main

While working on BFS discovered a bug in the address computations for the GPU backend when dealing with arrays of products.

Discovered a few issues that were causing this

  1. The size of the element type of an array was not being put in parentheses leading to very weird computations
  2. Offsets into a record were not being computed correctly (there was an unnecessary subtraction)
  3. Offsets into a record were not being generated in code
  4. When processing indices the type of the current collection was not being updated which is necessary to properly compute sizes
  5. (Actually unrelated, but noticed it) Sizes of arrays were not being computed properly, it was using get_alignment as the element size rather than get_size.

See comments for some questions I have related to extra_dim_collects.

Merge request reports