Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
Hercules
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
llvm
Hercules
Merge requests
!141
Fix crash in einsum
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fix crash in einsum
fix_einsum
into
main
Overview
0
Commits
2
Pipelines
2
Changes
2
Merged
rarbore2
requested to merge
fix_einsum
into
main
2 months ago
Overview
0
Commits
2
Pipelines
2
Changes
2
Expand
Fix crash in einsum where a lack of expression for inner reduce causes computing outer expression to crash.
0
0
Merge request reports
Compare
main
version 1
405cdda7
2 months ago
main (base)
and
latest version
latest version
0abd27fe
2 commits,
2 months ago
version 1
405cdda7
1 commit,
2 months ago
2 files
+
7
−
4
Side-by-side
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
hercules_ir/src/einsum.rs
+
2
−
3
Options
@@ -235,12 +235,11 @@ impl<'a> EinsumContext<'a> {
@@ -235,12 +235,11 @@ impl<'a> EinsumContext<'a> {
control
:
_
,
control
:
_
,
init
:
_
,
init
:
_
,
reduct
:
_
,
reduct
:
_
,
}
=>
{
}
if
let
Some
(
reduce
)
=
self
.so_far
.get
(
&
id
)
=>
{
let
reduce
=
self
.so_far
[
&
id
];
// Substitute opaque uses of thread ID nodes in inner expression
// Substitute opaque uses of thread ID nodes in inner expression
// with thread ID math expression, and increment inner-fork
// with thread ID math expression, and increment inner-fork
// dimensions (alpha renaming).
// dimensions (alpha renaming).
return
self
.substitute_new_dims
(
reduce
);
return
self
.substitute_new_dims
(
*
reduce
);
}
}
_
=>
MathExpr
::
OpaqueNode
(
id
),
_
=>
MathExpr
::
OpaqueNode
(
id
),
};
};
Loading