fix reduce cycles

hercules_ir/src/fork_join_analysis.rs

@@ -140,23 +140,23 @@ fn reduce_cycle_dfs_helper(
     }
 
     current_visited.insert(iter);
-    let found_reduce = get_uses(&function.nodes[iter.idx()])
-        .as_ref()
-        .into_iter()
-        .any(|u| {
-            !current_visited.contains(u)
-                && !function.nodes[u.idx()].is_control()
-                && isnt_outside_fork_join(*u)
-                && reduce_cycle_dfs_helper(
-                    function,
-                    *u,
-                    fork,
-                    reduce,
-                    current_visited,
-                    in_cycle,
-                    fork_join_nest,
-                )
-        });
+    let mut found_reduce = false;
+
+    // This doesn't short circuit on purpose.
+    for u in get_uses(&function.nodes[iter.idx()]).as_ref() {
+        found_reduce |= !current_visited.contains(u)
+            && !function.nodes[u.idx()].is_control()
+            && isnt_outside_fork_join(*u)
+            && reduce_cycle_dfs_helper(
+                function,
+                *u,
+                fork,
+                reduce,
+                current_visited,
+                in_cycle,
+                fork_join_nest,
+            )
+    }
     if found_reduce {
         in_cycle.insert(iter);
     }

juno_samples/fork_join_tests/src/cpu.sch

@@ -18,6 +18,9 @@ fixpoint panic after 20 {
   fork-guard-elim(*);
   fork-coalesce(*);
 }
+gvn(*);
+phi-elim(*);
+dce(*);
 
 gvn(*);
 phi-elim(*);
@@ -27,6 +30,12 @@ fixpoint panic after 20 {
   infer-schedules(*);
 }
 fork-split(*);
+gvn(*);
+phi-elim(*);
+dce(*);
 unforkify(*);
+gvn(*);
+phi-elim(*);
+dce(*);
 
 gcm(*);