-
- Downloads
[SPARK-14868][BUILD] Enable NewLineAtEofChecker in checkstyle and fix lint-java errors
## What changes were proposed in this pull request? Spark uses `NewLineAtEofChecker` rule in Scala by ScalaStyle. And, most Java code also comply with the rule. This PR aims to enforce the same rule `NewlineAtEndOfFile` by CheckStyle explicitly. Also, this fixes lint-java errors since SPARK-14465. The followings are the items. - Adds a new line at the end of the files (19 files) - Fixes 25 lint-java errors (12 RedundantModifier, 6 **ArrayTypeStyle**, 2 LineLength, 2 UnusedImports, 2 RegexpSingleline, 1 ModifierOrder) ## How was this patch tested? After the Jenkins test succeeds, `dev/lint-java` should pass. (Currently, Jenkins dose not run lint-java.) ```bash $ dev/lint-java Using `mvn` from path: /usr/local/bin/mvn Checkstyle checks passed. ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes #12632 from dongjoon-hyun/SPARK-14868.
Showing
- mllib/src/main/scala/org/apache/spark/mllib/package-info.java 1 addition, 1 deletion...b/src/main/scala/org/apache/spark/mllib/package-info.java
- mllib/src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java 3 additions, 3 deletions...rk/ml/classification/JavaRandomForestClassifierSuite.java
- mllib/src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java 3 additions, 3 deletions...e/spark/ml/regression/JavaRandomForestRegressorSuite.java
- sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java 0 additions, 1 deletion.../datasources/parquet/SpecificParquetRecordReaderBase.java
- streaming/src/main/scala/org/apache/spark/streaming/api/java/package-info.java 1 addition, 1 deletion...ala/org/apache/spark/streaming/api/java/package-info.java
- streaming/src/main/scala/org/apache/spark/streaming/dstream/package-info.java 1 addition, 1 deletion...cala/org/apache/spark/streaming/dstream/package-info.java
Please register or sign in to comment