Skip to content
Snippets Groups Projects
Commit bcc7373f authored by Kousuke Saruta's avatar Kousuke Saruta Committed by Josh Rosen
Browse files

[SPARK-12821][BUILD] Style checker should run when some configuration files...

[SPARK-12821][BUILD] Style checker should run when some configuration files for style are modified but any source files are not.

When running the `run-tests` script, style checkers run only when any source files are modified but they should run when configuration files related to style are modified.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #10754 from sarutak/SPARK-12821.
parent 902667fd
No related branches found
No related tags found
No related merge requests found
...@@ -529,9 +529,14 @@ def main(): ...@@ -529,9 +529,14 @@ def main():
run_apache_rat_checks() run_apache_rat_checks()
# style checks # style checks
if not changed_files or any(f.endswith(".scala") for f in changed_files): if not changed_files or any(f.endswith(".scala")
or f.endswith("scalastyle-config.xml")
for f in changed_files):
run_scala_style_checks() run_scala_style_checks()
if not changed_files or any(f.endswith(".java") for f in changed_files): if not changed_files or any(f.endswith(".java")
or f.endswith("checkstyle.xml")
or f.endswith("checkstyle-suppressions.xml")
for f in changed_files):
# run_java_style_checks() # run_java_style_checks()
pass pass
if not changed_files or any(f.endswith(".py") for f in changed_files): if not changed_files or any(f.endswith(".py") for f in changed_files):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment