Skip to content
Snippets Groups Projects
Commit b2ebf429 authored by Patrick Wendell's avatar Patrick Wendell Committed by Xiangrui Meng
Browse files

HOTFIX: bug caused by #941

This patch should have qualified the use of PIPE. This needs to be back ported into 0.9 and 1.0.

Author: Patrick Wendell <pwendell@gmail.com>

Closes #1108 from pwendell/hotfix and squashes the following commits:

711c58d [Patrick Wendell] HOTFIX: bug caused by #941
parent a14807e8
No related branches found
No related tags found
No related merge requests found
...@@ -693,7 +693,7 @@ def ssh(host, opts, command): ...@@ -693,7 +693,7 @@ def ssh(host, opts, command):
def _check_output(*popenargs, **kwargs): def _check_output(*popenargs, **kwargs):
if 'stdout' in kwargs: if 'stdout' in kwargs:
raise ValueError('stdout argument not allowed, it will be overridden.') raise ValueError('stdout argument not allowed, it will be overridden.')
process = subprocess.Popen(stdout=PIPE, *popenargs, **kwargs) process = subprocess.Popen(stdout=subprocess.PIPE, *popenargs, **kwargs)
output, unused_err = process.communicate() output, unused_err = process.communicate()
retcode = process.poll() retcode = process.poll()
if retcode: if retcode:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment