Skip to content
Snippets Groups Projects
Commit 47011e68 authored by Reynold Xin's avatar Reynold Xin
Browse files

Use a tigher bound in logistic regression unit test's prediction validation.

parent e35966ae
No related branches found
No related tags found
No related merge requests found
...@@ -21,11 +21,12 @@ import scala.util.Random ...@@ -21,11 +21,12 @@ import scala.util.Random
import org.scalatest.BeforeAndAfterAll import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite import org.scalatest.FunSuite
import org.scalatest.matchers.ShouldMatchers
import spark.SparkContext import spark.SparkContext
class LogisticRegressionSuite extends FunSuite with BeforeAndAfterAll { class LogisticRegressionSuite extends FunSuite with BeforeAndAfterAll with ShouldMatchers {
val sc = new SparkContext("local", "test") val sc = new SparkContext("local", "test")
override def afterAll() { override def afterAll() {
...@@ -64,8 +65,8 @@ class LogisticRegressionSuite extends FunSuite with BeforeAndAfterAll { ...@@ -64,8 +65,8 @@ class LogisticRegressionSuite extends FunSuite with BeforeAndAfterAll {
val numOffPredictions = predictions.zip(input).filter { case (prediction, (expected, _)) => val numOffPredictions = predictions.zip(input).filter { case (prediction, (expected, _)) =>
(prediction != expected) (prediction != expected)
}.size }.size
// At least 80% of the predictions should be on. // At least 83% of the predictions should be on.
assert(numOffPredictions < input.length / 5) ((input.length - numOffPredictions).toDouble / input.length) should be > 0.83
} }
// Test if we can correctly learn A, B where Y = logistic(A + B*X) // Test if we can correctly learn A, B where Y = logistic(A + B*X)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment