-
- Downloads
SPARK-1279: Fix improper use of SimpleDateFormat
`SimpleDateFormat` is not thread-safe. Some places use the same SimpleDateFormat object without safeguard in the multiple threads. It will cause that the Web UI displays improper date. This PR creates a new `SimpleDateFormat` every time when it's necessary. Another solution is using `ThreadLocal` to store a `SimpleDateFormat` in each thread. If this PR impacts the performance, I can change to the latter one. Author: zsxwing <zsxwing@gmail.com> Closes #179 from zsxwing/SPARK-1278 and squashes the following commits: 21fabd3 [zsxwing] SPARK-1278: Fix improper use of SimpleDateFormat
Showing
- core/src/main/scala/org/apache/spark/deploy/master/Master.scala 3 additions, 3 deletions...rc/main/scala/org/apache/spark/deploy/master/Master.scala
- core/src/main/scala/org/apache/spark/deploy/master/ui/IndexPage.scala 4 additions, 4 deletions...n/scala/org/apache/spark/deploy/master/ui/IndexPage.scala
- core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 2 additions, 2 deletions...rc/main/scala/org/apache/spark/deploy/worker/Worker.scala
- core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala 4 additions, 2 deletions...src/main/scala/org/apache/spark/scheduler/JobLogger.scala
- core/src/main/scala/org/apache/spark/ui/WebUI.scala 8 additions, 5 deletionscore/src/main/scala/org/apache/spark/ui/WebUI.scala
- core/src/main/scala/org/apache/spark/ui/jobs/JobProgressUI.scala 0 additions, 2 deletions...c/main/scala/org/apache/spark/ui/jobs/JobProgressUI.scala
- core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala 2 additions, 3 deletionscore/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
- core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala 2 additions, 3 deletions.../src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
- core/src/main/scala/org/apache/spark/util/FileLogger.scala 5 additions, 2 deletionscore/src/main/scala/org/apache/spark/util/FileLogger.scala
Loading
Please register or sign in to comment