Skip to content
Snippets Groups Projects
  • wm624@hotmail.com's avatar
    e328f577
    [SPARK-17002][CORE] Document that spark.ssl.protocol. is required for SSL · e328f577
    wm624@hotmail.com authored
    ## What changes were proposed in this pull request?
    
    `spark.ssl.enabled`=true, but failing to set `spark.ssl.protocol` will fail and throw meaningless exception. `spark.ssl.protocol` is required when `spark.ssl.enabled`.
    
    Improvement: require `spark.ssl.protocol` when initializing SSLContext, otherwise throws an exception to indicate that.
    
    Remove the OrElse("default").
    
    Document this requirement in configure.md
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    
    Manual tests:
    Build document and check document
    
    Configure `spark.ssl.enabled` only, it throws exception below:
    6/08/16 16:04:37 INFO SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users  with view permissions: Set(mwang); groups with view permissions: Set(); users  with modify permissions: Set(mwang); groups with modify permissions: Set()
    Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: spark.ssl.protocol is required when enabling SSL connections.
    	at scala.Predef$.require(Predef.scala:224)
    	at org.apache.spark.SecurityManager.<init>(SecurityManager.scala:285)
    	at org.apache.spark.deploy.master.Master$.startRpcEnvAndEndpoint(Master.scala:1026)
    	at org.apache.spark.deploy.master.Master$.main(Master.scala:1011)
    	at org.apache.spark.deploy.master.Master.main(Master.scala)
    
    Configure `spark.ssl.protocol`  and `spark.ssl.protocol`
    It works fine.
    
    Author: wm624@hotmail.com <wm624@hotmail.com>
    
    Closes #14674 from wangmiao1981/ssl.
    e328f577
    History
    [SPARK-17002][CORE] Document that spark.ssl.protocol. is required for SSL
    wm624@hotmail.com authored
    ## What changes were proposed in this pull request?
    
    `spark.ssl.enabled`=true, but failing to set `spark.ssl.protocol` will fail and throw meaningless exception. `spark.ssl.protocol` is required when `spark.ssl.enabled`.
    
    Improvement: require `spark.ssl.protocol` when initializing SSLContext, otherwise throws an exception to indicate that.
    
    Remove the OrElse("default").
    
    Document this requirement in configure.md
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    
    Manual tests:
    Build document and check document
    
    Configure `spark.ssl.enabled` only, it throws exception below:
    6/08/16 16:04:37 INFO SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users  with view permissions: Set(mwang); groups with view permissions: Set(); users  with modify permissions: Set(mwang); groups with modify permissions: Set()
    Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: spark.ssl.protocol is required when enabling SSL connections.
    	at scala.Predef$.require(Predef.scala:224)
    	at org.apache.spark.SecurityManager.<init>(SecurityManager.scala:285)
    	at org.apache.spark.deploy.master.Master$.startRpcEnvAndEndpoint(Master.scala:1026)
    	at org.apache.spark.deploy.master.Master$.main(Master.scala:1011)
    	at org.apache.spark.deploy.master.Master.main(Master.scala)
    
    Configure `spark.ssl.protocol`  and `spark.ssl.protocol`
    It works fine.
    
    Author: wm624@hotmail.com <wm624@hotmail.com>
    
    Closes #14674 from wangmiao1981/ssl.