Skip to content
  • Dongjoon Hyun's avatar
    aea30a1a
    [SPARK-14465][BUILD] Checkstyle should check all Java files · aea30a1a
    Dongjoon Hyun authored
    ## What changes were proposed in this pull request?
    
    Currently, `checkstyle` is configured to check the files under `src/main/java`. However, Spark has Java files in `src/main/scala`, too. This PR fixes the following configuration in `pom.xml` and the unchecked-so-far violations on those files.
    ```xml
    -<sourceDirectory>${basedir}/src/main/java</sourceDirectory>
    +<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories>
    ```
    
    ## How was this patch tested?
    
    After passing the Jenkins build and manually `dev/lint-java`. (Note that Jenkins does not run `lint-java`)
    
    Author: Dongjoon Hyun <dongjoon@apache.org>
    
    Closes #12242 from dongjoon-hyun/SPARK-14465.
    aea30a1a
    [SPARK-14465][BUILD] Checkstyle should check all Java files
    Dongjoon Hyun authored
    ## What changes were proposed in this pull request?
    
    Currently, `checkstyle` is configured to check the files under `src/main/java`. However, Spark has Java files in `src/main/scala`, too. This PR fixes the following configuration in `pom.xml` and the unchecked-so-far violations on those files.
    ```xml
    -<sourceDirectory>${basedir}/src/main/java</sourceDirectory>
    +<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories>
    ```
    
    ## How was this patch tested?
    
    After passing the Jenkins build and manually `dev/lint-java`. (Note that Jenkins does not run `lint-java`)
    
    Author: Dongjoon Hyun <dongjoon@apache.org>
    
    Closes #12242 from dongjoon-hyun/SPARK-14465.
Loading