Skip to content
Snippets Groups Projects
  • Patrick Wendell's avatar
    94ccf869
    Merge pull request #569 from pwendell/merge-fixes. · 94ccf869
    Patrick Wendell authored
    Fixes bug where merges won't close associated pull request.
    
    Previously we added "Closes #XX" in the title. Github will sometimes
    linbreak the title in a way that causes this to not work. This patch
    instead adds the line in the body.
    
    This also makes the commit format more concise for merge commits.
    We might consider just dropping those in the future.
    
    Author: Patrick Wendell <pwendell@gmail.com>
    
    Closes #569 and squashes the following commits:
    
    732eba1 [Patrick Wendell] Fixes bug where merges won't close associated pull request.
    94ccf869
    History
    Merge pull request #569 from pwendell/merge-fixes.
    Patrick Wendell authored
    Fixes bug where merges won't close associated pull request.
    
    Previously we added "Closes #XX" in the title. Github will sometimes
    linbreak the title in a way that causes this to not work. This patch
    instead adds the line in the body.
    
    This also makes the commit format more concise for merge commits.
    We might consider just dropping those in the future.
    
    Author: Patrick Wendell <pwendell@gmail.com>
    
    Closes #569 and squashes the following commits:
    
    732eba1 [Patrick Wendell] Fixes bug where merges won't close associated pull request.