Skip to content
Snippets Groups Projects
  • Josh Rosen's avatar
    4ba26735
    [HOTFIX] Fix broken Mima tests on the master branch · 4ba26735
    Josh Rosen authored
    By merging #2268, which bumped the Spark version to 1.2.0-SNAPSHOT, I inadvertently broke the Mima binary compatibility tests.  The issue is that we were comparing 1.2.0-SNAPSHOT against Spark 1.0.0 without using any Mima excludes.  The right long-term fix for this is probably to publish nightly snapshots on Maven central and change the master branch to test binary compatibility against the current release candidate branch's snapshots until that release is finalized.
    
    As a short-term fix until 1.1.0 is published on Maven central, I've configured the build to test the master branch for binary compatibility against the 1.1.0-RC4 jars.  I'll loop back and remove the Apache staging repo as soon as 1.1.0 final is available.
    
    Author: Josh Rosen <joshrosen@apache.org>
    
    Closes #2315 from JoshRosen/mima-fix and squashes the following commits:
    
    776bc2c [Josh Rosen] Add two excludes to workaround Mima annotation issues.
    ec90e21 [Josh Rosen] Add deploy and graphx to 1.2 MiMa excludes.
    57569be [Josh Rosen] Fix MiMa tests in master branch; test against 1.1.0 RC.
    4ba26735
    History
    [HOTFIX] Fix broken Mima tests on the master branch
    Josh Rosen authored
    By merging #2268, which bumped the Spark version to 1.2.0-SNAPSHOT, I inadvertently broke the Mima binary compatibility tests.  The issue is that we were comparing 1.2.0-SNAPSHOT against Spark 1.0.0 without using any Mima excludes.  The right long-term fix for this is probably to publish nightly snapshots on Maven central and change the master branch to test binary compatibility against the current release candidate branch's snapshots until that release is finalized.
    
    As a short-term fix until 1.1.0 is published on Maven central, I've configured the build to test the master branch for binary compatibility against the 1.1.0-RC4 jars.  I'll loop back and remove the Apache staging repo as soon as 1.1.0 final is available.
    
    Author: Josh Rosen <joshrosen@apache.org>
    
    Closes #2315 from JoshRosen/mima-fix and squashes the following commits:
    
    776bc2c [Josh Rosen] Add two excludes to workaround Mima annotation issues.
    ec90e21 [Josh Rosen] Add deploy and graphx to 1.2 MiMa excludes.
    57569be [Josh Rosen] Fix MiMa tests in master branch; test against 1.1.0 RC.