From 20af780dd765de9e3efa9c5ae9a3e9e41e5985c5 Mon Sep 17 00:00:00 2001
From: hsharif3 <hsharif3@illinois.edu>
Date: Wed, 3 Feb 2021 16:00:57 -0600
Subject: [PATCH] Adding necessary links to Keras README.md

---
 hpvm/projects/keras/README.md | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/hpvm/projects/keras/README.md b/hpvm/projects/keras/README.md
index e092715a07..3dab321f23 100644
--- a/hpvm/projects/keras/README.md
+++ b/hpvm/projects/keras/README.md
@@ -69,11 +69,15 @@ python src/${BENCH_NAME}.py  [hpvm_reload|keras_reload]  [frontend]
 
 **Parameters:**
 
-`hpvm_reload` : Reloads HPVM weights (format used in `model_params` found here: [ADD link to Google Drive]) from directory specified in Benchmark constructor. 
+`hpvm_reload` : Reloads HPVM weights ('.bin' binary format used in `model_params` found here: https://gitlab.engr.illinois.edu/llvm/hpvm/-/tree/approx_hpvm_reorg_keras/hpvm/test/dnn_benchmarks/model_params) from directory path specified in the [Benchmark class constructor](https://gitlab.engr.illinois.edu/llvm/hpvm/-/blob/approx_hpvm_reorg_keras/hpvm/projects/keras/src/Benchmark.py#L17). 
 
-`keras_reload`: Reloads weights in Keras `.h5` file format 
+`keras_reload`: Reloads weights in Keras `.h5` file format with path to file specified in [Benchmark class constructor](https://gitlab.engr.illinois.edu/llvm/hpvm/-/blob/approx_hpvm_reorg_keras/hpvm/projects/keras/src/Benchmark.py#L20)
 
-`frontend`: Invokes the HPVM frontend and dumps weights (in HPVM `.bin` format) in directory specified
+`frontend`: Invokes the HPVM frontend and dumps weights (in HPVM `.bin` format) in the output directory specified. The constructor requires two paths:
+
+* `data_dir`: Directory to dump weights specified specified in [constructor](https://gitlab.engr.illinois.edu/llvm/hpvm/-/blob/approx_hpvm_reorg_keras/hpvm/projects/keras/src/Benchmark.py#L21)
+ 
+* `src_dir`: Directory to dump ApproxHPVM sources in HPVM-C (C with HPVM compiler intrinsics) specified in [constructor](https://gitlab.engr.illinois.edu/llvm/hpvm/-/blob/approx_hpvm_reorg_keras/hpvm/projects/keras/src/Benchmark.py#L22) 
 
 
 
-- 
GitLab