From e149d4fd50ef6b643df9c7b5420007d1fa56c4c0 Mon Sep 17 00:00:00 2001
From: Aaron Councilman <aaronjc4@illinois.edu>
Date: Fri, 14 Feb 2025 09:30:27 -0600
Subject: [PATCH 1/4] Usecase for rename
---
juno_samples/fork_join_tests/src/cpu.sch | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/juno_samples/fork_join_tests/src/cpu.sch b/juno_samples/fork_join_tests/src/cpu.sch
index abc2fde0..4cebc044 100644
--- a/juno_samples/fork_join_tests/src/cpu.sch
+++ b/juno_samples/fork_join_tests/src/cpu.sch
@@ -14,6 +14,7 @@ cpu(auto.test5);
cpu(auto.test7);
cpu(auto.test8);
+let test1_cpu = auto.test1;
ip-sroa(*);
sroa(*);
@@ -39,7 +40,10 @@ dce(*);
fixpoint panic after 20 {
infer-schedules(*);
}
-fork-split(auto.test1);
+
+let out = fork-split(test1_cpu);
+let first_fork = out.test1_cpu.fj1;
+
fixpoint panic after 20 {
unroll(auto.test1);
}
--
GitLab
From 16acf8359f5361a741aeb82409de2067a8bc1ef0 Mon Sep 17 00:00:00 2001
From: Aaron Councilman <aaronjc4@illinois.edu>
Date: Fri, 14 Feb 2025 09:38:37 -0600
Subject: [PATCH 2/4] Skeleton for rename pass
---
juno_scheduler/src/compile.rs | 1 +
juno_scheduler/src/ir.rs | 2 ++
juno_scheduler/src/lib.rs | 2 +-
juno_scheduler/src/pm.rs | 25 +++++++++++++++++++++++++
4 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/juno_scheduler/src/compile.rs b/juno_scheduler/src/compile.rs
index 725bcca5..5603ea8e 100644
--- a/juno_scheduler/src/compile.rs
+++ b/juno_scheduler/src/compile.rs
@@ -122,6 +122,7 @@ impl FromStr for Appliable {
"phi-elim" => Ok(Appliable::Pass(ir::Pass::PhiElim)),
"predication" => Ok(Appliable::Pass(ir::Pass::Predication)),
"reduce-slf" => Ok(Appliable::Pass(ir::Pass::ReduceSLF)),
+ "rename" => Ok(Appliable::Pass(ir::Pass::Rename)),
"reuse-products" => Ok(Appliable::Pass(ir::Pass::ReuseProducts)),
"simplify-cfg" => Ok(Appliable::Pass(ir::Pass::SimplifyCFG)),
"slf" | "store-load-forward" => Ok(Appliable::Pass(ir::Pass::SLF)),
diff --git a/juno_scheduler/src/ir.rs b/juno_scheduler/src/ir.rs
index c8097213..52bafa2c 100644
--- a/juno_scheduler/src/ir.rs
+++ b/juno_scheduler/src/ir.rs
@@ -27,6 +27,7 @@ pub enum Pass {
PhiElim,
Predication,
ReduceSLF,
+ Rename,
ReuseProducts,
SLF,
SROA,
@@ -42,6 +43,7 @@ impl Pass {
pub fn num_args(&self) -> usize {
match self {
Pass::Xdot => 1,
+ Pass::Rename => 1,
Pass::ForkChunk => 4,
Pass::ForkFissionBufferize => 2,
Pass::ForkInterchange => 2,
diff --git a/juno_scheduler/src/lib.rs b/juno_scheduler/src/lib.rs
index d4ab432a..03ad0111 100644
--- a/juno_scheduler/src/lib.rs
+++ b/juno_scheduler/src/lib.rs
@@ -1,6 +1,6 @@
#![feature(exact_size_is_empty)]
+#![feature(let_chains)]
-use std::collections::{HashMap, HashSet};
use std::fs::File;
use std::io::Read;
diff --git a/juno_scheduler/src/pm.rs b/juno_scheduler/src/pm.rs
index aa09868f..1c4baeec 100644
--- a/juno_scheduler/src/pm.rs
+++ b/juno_scheduler/src/pm.rs
@@ -2163,6 +2163,31 @@ fn run_pass(
changed |= func.modified();
}
}
+ Pass::Rename => {
+ assert!(args.len() == 1);
+ let new_name =
+ match args[0] {
+ Value::String { val } => val,
+ _ => {
+ return Err(SchedulerError::PassError {
+ pass: "rename".to_string(),
+ error: "expected string argument".to_string(),
+ });
+ }
+ };
+ // TODO: Verify new name is not used
+
+ if let Some(funcs) = selection_of_functions(pm, selection)
+ && funcs.len() == 1 {
+ let func = funcs[0];
+ pm.functions[func.idx()].name = new_name;
+ } else {
+ return Err(SchedulerError::PassError {
+ pass: "rename".to_string(),
+ error: "must be applied to the entirety of a single function".to_string(),
+ });
+ };
+ }
Pass::ReuseProducts => {
assert!(args.is_empty());
pm.make_reverse_postorders();
--
GitLab
From 4bf55a12987e674f0b4df9046b3c3b928ed57ef9 Mon Sep 17 00:00:00 2001
From: Aaron Councilman <aaronjc4@illinois.edu>
Date: Fri, 14 Feb 2025 09:39:53 -0600
Subject: [PATCH 3/4] Add fresh name check
---
juno_scheduler/src/pm.rs | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/juno_scheduler/src/pm.rs b/juno_scheduler/src/pm.rs
index 1c4baeec..20774c5d 100644
--- a/juno_scheduler/src/pm.rs
+++ b/juno_scheduler/src/pm.rs
@@ -2175,7 +2175,12 @@ fn run_pass(
});
}
};
- // TODO: Verify new name is not used
+ if pm.functions.iter().any(|f| f.name == new_name) {
+ return Err(SchedulerError::PassError {
+ pass: "rename".to_string(),
+ error: format!("function with name {} already exists", new_name),
+ });
+ }
if let Some(funcs) = selection_of_functions(pm, selection)
&& funcs.len() == 1 {
--
GitLab
From 06f747ca1079af9dc983ef8a070518daf3670eba Mon Sep 17 00:00:00 2001
From: Aaron Councilman <aaronjc4@illinois.edu>
Date: Fri, 14 Feb 2025 11:45:31 -0600
Subject: [PATCH 4/4] Add strings to scheduling language, add rename
---
juno_samples/fork_join_tests/src/cpu.sch | 1 +
juno_scheduler/src/compile.rs | 5 +++
juno_scheduler/src/ir.rs | 3 ++
juno_scheduler/src/lang.l | 1 +
juno_scheduler/src/lang.y | 5 ++-
juno_scheduler/src/pm.rs | 47 +++++++++++++++++-------
6 files changed, 47 insertions(+), 15 deletions(-)
diff --git a/juno_samples/fork_join_tests/src/cpu.sch b/juno_samples/fork_join_tests/src/cpu.sch
index 4cebc044..7c416e90 100644
--- a/juno_samples/fork_join_tests/src/cpu.sch
+++ b/juno_samples/fork_join_tests/src/cpu.sch
@@ -15,6 +15,7 @@ cpu(auto.test7);
cpu(auto.test8);
let test1_cpu = auto.test1;
+rename["test1_cpu"](test1_cpu);
ip-sroa(*);
sroa(*);
diff --git a/juno_scheduler/src/compile.rs b/juno_scheduler/src/compile.rs
index df72a1a3..0652f8f2 100644
--- a/juno_scheduler/src/compile.rs
+++ b/juno_scheduler/src/compile.rs
@@ -434,6 +434,11 @@ fn compile_expr(
parser::Expr::Boolean { span: _, val } => {
Ok(ExprResult::Expr(ir::ScheduleExp::Boolean { val }))
}
+ parser::Expr::String { span } => {
+ let string = lexer.span_str(span);
+ let val = string[1..string.len() - 1].to_string();
+ Ok(ExprResult::Expr(ir::ScheduleExp::String { val }))
+ }
parser::Expr::Field {
span: _,
lhs,
diff --git a/juno_scheduler/src/ir.rs b/juno_scheduler/src/ir.rs
index c495f2a6..e92f1d37 100644
--- a/juno_scheduler/src/ir.rs
+++ b/juno_scheduler/src/ir.rs
@@ -83,6 +83,9 @@ pub enum ScheduleExp {
Boolean {
val: bool,
},
+ String {
+ val: String,
+ },
Field {
collect: Box<ScheduleExp>,
field: String,
diff --git a/juno_scheduler/src/lang.l b/juno_scheduler/src/lang.l
index 9d4c34bf..afe596b2 100644
--- a/juno_scheduler/src/lang.l
+++ b/juno_scheduler/src/lang.l
@@ -46,5 +46,6 @@ stop[\t \n\r]+after "stop_after"
[a-zA-Z][a-zA-Z0-9_\-]*! "MACRO"
[a-zA-Z][a-zA-Z0-9_\-]* "ID"
[0-9]+ "INT"
+\"[a-zA-Z0-9_\-\s\.]*\" "STRING"
. "UNMATCHED"
diff --git a/juno_scheduler/src/lang.y b/juno_scheduler/src/lang.y
index 9cb72842..584bf2a4 100644
--- a/juno_scheduler/src/lang.y
+++ b/juno_scheduler/src/lang.y
@@ -1,6 +1,6 @@
%start Schedule
-%avoid_insert "ID" "INT"
+%avoid_insert "ID" "INT" "STRING"
%expect-unused Unmatched 'UNMATCHED'
%%
@@ -47,6 +47,8 @@ Expr -> Expr
{ Expr::Boolean { span: $span, val: true } }
| 'false'
{ Expr::Boolean { span: $span, val: false } }
+ | 'STRING'
+ { Expr::String { span: $span } }
| Expr '.' 'ID'
{ Expr::Field { span: $span, lhs: Box::new($1), field: span_of_tok($3) } }
| Expr '@' 'ID'
@@ -155,6 +157,7 @@ pub enum Expr {
Variable { span: Span },
Integer { span: Span },
Boolean { span: Span, val: bool },
+ String { span: Span },
Field { span: Span, lhs: Box<Expr>, field: Span },
BlockExpr { span: Span, body: Box<OperationList> },
Record { span: Span, fields: Vec<(Span, Expr)> },
diff --git a/juno_scheduler/src/pm.rs b/juno_scheduler/src/pm.rs
index 0df691ea..9c51276b 100644
--- a/juno_scheduler/src/pm.rs
+++ b/juno_scheduler/src/pm.rs
@@ -29,6 +29,7 @@ pub enum Value {
Selection { selection: Vec<Value> },
Integer { val: usize },
Boolean { val: bool },
+ String { val: String },
}
#[derive(Debug, Copy, Clone)]
@@ -70,6 +71,9 @@ impl Value {
Value::Boolean { .. } => Err(SchedulerError::SemanticError(
"Expected labels, found boolean".to_string(),
)),
+ Value::String { .. } => Err(SchedulerError::SemanticError(
+ "Expected labels, found string".to_string(),
+ )),
}
}
@@ -99,6 +103,9 @@ impl Value {
Value::Boolean { .. } => Err(SchedulerError::SemanticError(
"Expected functions, found boolean".to_string(),
)),
+ Value::String { .. } => Err(SchedulerError::SemanticError(
+ "Expected functions, found string".to_string(),
+ )),
}
}
@@ -130,6 +137,9 @@ impl Value {
Value::Boolean { .. } => Err(SchedulerError::SemanticError(
"Expected code locations, found boolean".to_string(),
)),
+ Value::String { .. } => Err(SchedulerError::SemanticError(
+ "Expected code locations, found string".to_string(),
+ )),
}
}
}
@@ -998,6 +1008,7 @@ fn interp_expr(
}
ScheduleExp::Integer { val } => Ok((Value::Integer { val: *val }, false)),
ScheduleExp::Boolean { val } => Ok((Value::Boolean { val: *val }, false)),
+ ScheduleExp::String { val } => Ok((Value::String { val: val.clone() }, false)),
ScheduleExp::Field { collect, field } => {
let (lhs, changed) = interp_expr(pm, collect, stringtab, env, functions)?;
match lhs {
@@ -1005,7 +1016,8 @@ fn interp_expr(
| Value::Selection { .. }
| Value::Everything { .. }
| Value::Integer { .. }
- | Value::Boolean { .. } => Err(SchedulerError::UndefinedField(field.clone())),
+ | Value::Boolean { .. }
+ | Value::String { .. } => Err(SchedulerError::UndefinedField(field.clone())),
Value::JunoFunction { func } => {
match pm.labels.borrow().iter().position(|s| s == field) {
None => Err(SchedulerError::UndefinedLabel(field.clone())),
@@ -1260,6 +1272,7 @@ fn update_value(
Value::Everything {} => Some(Value::Everything {}),
Value::Integer { val } => Some(Value::Integer { val }),
Value::Boolean { val } => Some(Value::Boolean { val }),
+ Value::String { val } => Some(Value::String { val }),
}
}
@@ -2193,16 +2206,15 @@ fn run_pass(
}
Pass::Rename => {
assert!(args.len() == 1);
- let new_name =
- match args[0] {
- Value::String { val } => val,
- _ => {
- return Err(SchedulerError::PassError {
- pass: "rename".to_string(),
- error: "expected string argument".to_string(),
- });
- }
- };
+ let new_name = match args[0] {
+ Value::String { ref val } => val.clone(),
+ _ => {
+ return Err(SchedulerError::PassError {
+ pass: "rename".to_string(),
+ error: "expected string argument".to_string(),
+ });
+ }
+ };
if pm.functions.iter().any(|f| f.name == new_name) {
return Err(SchedulerError::PassError {
pass: "rename".to_string(),
@@ -2210,8 +2222,9 @@ fn run_pass(
});
}
- if let Some(funcs) = selection_of_functions(pm, selection)
- && funcs.len() == 1 {
+ if let Some(funcs) = selection_of_functions(pm, selection)
+ && funcs.len() == 1
+ {
let func = funcs[0];
pm.functions[func.idx()].name = new_name;
} else {
@@ -2364,7 +2377,13 @@ fn run_pass(
let Some(mut func) = func else {
continue;
};
- chunk_all_forks_unguarded(&mut func, fork_join_map, *dim_idx, *tile_size, *tile_order);
+ chunk_all_forks_unguarded(
+ &mut func,
+ fork_join_map,
+ *dim_idx,
+ *tile_size,
+ *tile_order,
+ );
changed |= func.modified();
}
pm.delete_gravestones();
--
GitLab