From 3491c89c0b04e98d633e4892d5f62d05c518066c Mon Sep 17 00:00:00 2001
From: Russel Arbore <russel.jma@gmail.com>
Date: Fri, 17 Jan 2025 15:00:21 -0800
Subject: [PATCH] re-commute for dc eq check
---
hercules_ir/src/typecheck.rs | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hercules_ir/src/typecheck.rs b/hercules_ir/src/typecheck.rs
index 262ce6f8..244d8d19 100644
--- a/hercules_ir/src/typecheck.rs
+++ b/hercules_ir/src/typecheck.rs
@@ -1,3 +1,4 @@
+use std::cmp::{max, min};
use std::collections::HashMap;
use std::iter::zip;
@@ -1152,8 +1153,15 @@ fn dyn_consts_match(
(DynamicConstant::Constant(x), DynamicConstant::Constant(y)) => x == y,
(DynamicConstant::Parameter(i), _) => input == dc_args[*i],
(DynamicConstant::Add(pl, pr), DynamicConstant::Add(il, ir))
- | (DynamicConstant::Sub(pl, pr), DynamicConstant::Sub(il, ir))
| (DynamicConstant::Mul(pl, pr), DynamicConstant::Mul(il, ir))
+ | (DynamicConstant::Min(pl, pr), DynamicConstant::Min(il, ir))
+ | (DynamicConstant::Max(pl, pr), DynamicConstant::Max(il, ir)) => {
+ // Normalize for associative ops by always looking at smaller DC ID
+ // as left arm and larger DC ID as right arm.
+ dyn_consts_match(dynamic_constants, dc_args, min(*pl, *pr), min(*il, *ir))
+ && dyn_consts_match(dynamic_constants, dc_args, max(*pl, *pr), max(*il, *ir))
+ }
+ (DynamicConstant::Sub(pl, pr), DynamicConstant::Sub(il, ir))
| (DynamicConstant::Div(pl, pr), DynamicConstant::Div(il, ir))
| (DynamicConstant::Rem(pl, pr), DynamicConstant::Rem(il, ir)) => {
dyn_consts_match(dynamic_constants, dc_args, *pl, *il)
--
GitLab