From de8ab313e1fe59f849a62e59349224581ff0b40a Mon Sep 17 00:00:00 2001
From: Tathagata Das <tathagata.das1565@gmail.com>
Date: Thu, 30 Jun 2016 18:06:04 +0800
Subject: [PATCH] [SPARK-12177][TEST] Removed test to avoid compilation issue
in scala 2.10
## What changes were proposed in this pull request?
The commented lines failed scala 2.10 build. This is because of change in behavior of case classes between 2.10 and 2.11. In scala 2.10, if companion object of a case class has explicitly defined apply(), then the implicit apply method is not generated. In scala 2.11 it is generated. Hence, the lines compile fine in 2.11 but not in 2.10.
This simply comments the tests to fix broken build. Correct solution is pending.
Author: Tathagata Das <tathagata.das1565@gmail.com>
Closes #13992 from tdas/SPARK-12177.
---
.../streaming/kafka010/JavaConsumerStrategySuite.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java b/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
index aba45f5de6..8d7c05b5a6 100644
--- a/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
+++ b/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
@@ -50,8 +50,8 @@ public class JavaConsumerStrategySuite implements Serializable {
JavaConverters.mapAsScalaMapConverter(offsets).asScala();
// make sure constructors can be called from java
- final ConsumerStrategy<String, String> sub0 =
- Subscribe.<String, String>apply(topics, kafkaParams, offsets);
+ // final ConsumerStrategy<String, String> sub0 = // does not compile in Scala 2.10
+ // Subscribe.<String, String>apply(topics, kafkaParams, offsets);
final ConsumerStrategy<String, String> sub1 =
Subscribe.<String, String>apply(sTopics, sKafkaParams, sOffsets);
final ConsumerStrategy<String, String> sub2 =
@@ -65,8 +65,8 @@ public class JavaConsumerStrategySuite implements Serializable {
sub1.executorKafkaParams().get("bootstrap.servers"),
sub3.executorKafkaParams().get("bootstrap.servers"));
- final ConsumerStrategy<String, String> asn0 =
- Assign.<String, String>apply(parts, kafkaParams, offsets);
+ // final ConsumerStrategy<String, String> asn0 = // does not compile in Scala 2.10
+ // Assign.<String, String>apply(parts, kafkaParams, offsets);
final ConsumerStrategy<String, String> asn1 =
Assign.<String, String>apply(sParts, sKafkaParams, sOffsets);
final ConsumerStrategy<String, String> asn2 =
--
GitLab