From a2ce0a2e309e70d74ae5d2ed203f7919a0f79397 Mon Sep 17 00:00:00 2001
From: Xiao Li <gatorsmile@gmail.com>
Date: Fri, 24 Mar 2017 23:27:42 -0700
Subject: [PATCH] [HOTFIX][SQL] Fix the failed test cases in
GeneratorFunctionSuite
### What changes were proposed in this pull request?
Multiple tests failed. Revert the changes on `supportCodegen` of `GenerateExec`. For example,
- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75194/testReport/
### How was this patch tested?
N/A
Author: Xiao Li <gatorsmile@gmail.com>
Closes #17425 from gatorsmile/turnOnCodeGenGenerateExec.
---
.../apache/spark/sql/GeneratorFunctionSuite.scala | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
index b9871afd59..cef5bbf0e8 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala
@@ -91,7 +91,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
val df = Seq((1, Seq(1, 2, 3)), (2, Seq())).toDF("a", "intList")
checkAnswer(
df.select(explode_outer('intList)),
- Row(1) :: Row(2) :: Row(3) :: Row(null) :: Nil)
+ Row(1) :: Row(2) :: Row(3) :: Nil)
}
test("single posexplode") {
@@ -105,7 +105,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
val df = Seq((1, Seq(1, 2, 3)), (2, Seq())).toDF("a", "intList")
checkAnswer(
df.select(posexplode_outer('intList)),
- Row(0, 1) :: Row(1, 2) :: Row(2, 3) :: Row(null, null) :: Nil)
+ Row(0, 1) :: Row(1, 2) :: Row(2, 3) :: Nil)
}
test("explode and other columns") {
@@ -161,7 +161,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
df.select(explode_outer('intList).as('int)).select('int),
- Row(1) :: Row(2) :: Row(3) :: Row(null) :: Nil)
+ Row(1) :: Row(2) :: Row(3) :: Nil)
checkAnswer(
df.select(explode('intList).as('int)).select(sum('int)),
@@ -182,7 +182,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
df.select(explode_outer('map)),
- Row("a", "b") :: Row(null, null) :: Row("c", "d") :: Nil)
+ Row("a", "b") :: Row("c", "d") :: Nil)
}
test("explode on map with aliases") {
@@ -198,7 +198,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
df.select(explode_outer('map).as("key1" :: "value1" :: Nil)).select("key1", "value1"),
- Row("a", "b") :: Row(null, null) :: Nil)
+ Row("a", "b") :: Nil)
}
test("self join explode") {
@@ -279,7 +279,7 @@ class GeneratorFunctionSuite extends QueryTest with SharedSQLContext {
)
checkAnswer(
df2.selectExpr("inline_outer(col1)"),
- Row(null, null) :: Row(3, "4") :: Row(5, "6") :: Nil
+ Row(3, "4") :: Row(5, "6") :: Nil
)
}
--
GitLab