diff --git a/core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java b/core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java index ea5f1a9abf69b52fabdba4625c481b39b54ccbcc..f6d1288cb263dbf88d76b86664a2dc85f1e231b0 100644 --- a/core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java +++ b/core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java @@ -130,10 +130,8 @@ public final class NioBufferedFileInputStream extends InputStream { StorageUtils.dispose(byteBuffer); } - //checkstyle.off: NoFinalizer @Override protected void finalize() throws IOException { close(); } - //checkstyle.on: NoFinalizer } diff --git a/dev/checkstyle-suppressions.xml b/dev/checkstyle-suppressions.xml index 6e15f6955984ec66c1b239009d5fa1f231b0f5d8..bbda824dd13b48ce3a80d547775b87f9004fdbb9 100644 --- a/dev/checkstyle-suppressions.xml +++ b/dev/checkstyle-suppressions.xml @@ -40,8 +40,6 @@ files="src/main/java/org/apache/hive/service/*"/> <suppress checks="MethodName" files="src/main/java/org/apache/hive/service/auth/PasswdAuthenticationProvider.java"/> - <suppress checks="NoFinalizer" - files="src/main/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java"/> <suppress checks="MethodName" files="sql/catalyst/src/main/java/org/apache/spark/sql/streaming/OutputMode.java"/> <suppress checks="MethodName" diff --git a/dev/checkstyle.xml b/dev/checkstyle.xml index 68aee4d4c97efebafdf0280aeb6c185aecc23533..53c284888ebb0039e17f1ec83f30dbb5a1d20661 100644 --- a/dev/checkstyle.xml +++ b/dev/checkstyle.xml @@ -131,7 +131,6 @@ <message key="name.invalidPattern" value="Method type name ''{0}'' must match pattern ''{1}''."/> </module> - <module name="NoFinalizer"/> <module name="GenericWhitespace"> <message key="ws.followed" value="GenericWhitespace ''{0}'' is followed by whitespace."/> diff --git a/pom.xml b/pom.xml index b0408ecca0f66aa38ad880d1e2eac3f9ae7bbfc7..83a35006707dae82c999cd09b6b0e630af2428ae 100644 --- a/pom.xml +++ b/pom.xml @@ -2488,6 +2488,7 @@ <artifactId>maven-checkstyle-plugin</artifactId> <version>2.17</version> <configuration> + <failOnViolation>false</failOnViolation> <includeTestSourceDirectory>true</includeTestSourceDirectory> <sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories> <testSourceDirectory>${basedir}/src/test/java</testSourceDirectory>