From 068256745052b0aa947dd8c16b1f1d73d8e4631e Mon Sep 17 00:00:00 2001
From: LY Lai <ly.lai@vpon.com>
Date: Tue, 27 May 2014 16:08:38 -0700
Subject: [PATCH] [SQL] SPARK-1922
Allow underscore in column name of a struct field https://issues.apache.org/jira/browse/SPARK-1922 .
Author: LY Lai <ly.lai@vpon.com>
Closes #873 from lyuanlai/master and squashes the following commits:
2253263 [LY Lai] Allow underscore in struct field column name
---
.../spark/sql/hive/HiveMetastoreCatalog.scala | 2 +-
.../sql/hive/HiveMetastoreCatalogSuite.scala | 32 +++++++++++++++++++
2 files changed, 33 insertions(+), 1 deletion(-)
create mode 100644 sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
index 636c4f7b93..9f74e0334f 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
@@ -201,7 +201,7 @@ object HiveMetastoreTypes extends RegexParsers {
}
protected lazy val structField: Parser[StructField] =
- "[a-zA-Z0-9]*".r ~ ":" ~ dataType ^^ {
+ "[a-zA-Z0-9_]*".r ~ ":" ~ dataType ^^ {
case name ~ _ ~ tpe => StructField(name, tpe, nullable = true)
}
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
new file mode 100644
index 0000000000..4a64b5f5eb
--- /dev/null
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import org.scalatest.FunSuite
+
+import org.apache.spark.sql.catalyst.types.{DataType, StructType}
+
+class HiveMetastoreCatalogSuite extends FunSuite {
+
+ test("struct field should accept underscore in sub-column name") {
+ val metastr = "struct<a: int, b_1: string, c: string>"
+
+ val datatype = HiveMetastoreTypes.toDataType(metastr)
+ assert(datatype.isInstanceOf[StructType])
+ }
+}
--
GitLab