From a9883f33c61d155ba602f512c0159a3e7ad8e4cc Mon Sep 17 00:00:00 2001
From: toole1 <toole1@6fbd10e7-183d-0410-a318-cb416676e4f2>
Date: Mon, 22 Aug 2011 15:52:01 +0000
Subject: [PATCH] jack
git-svn-id: https://subversion.cs.illinois.edu/svn/cs225@3401 6fbd10e7-183d-0410-a318-cb416676e4f2
---
TODO.txt | 5 +++--
proxy.cpp | 5 +----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/TODO.txt b/TODO.txt
index ac77011..85898ee 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -49,8 +49,6 @@ Critical
STYLE
Directory structure for config.ini includes
encrypt/secure pipe transfers
- x readFile() bug where lines have ':' or '?' in them?!
- long term style solution
x safer cross-platform exec()
x setenv("PATH"...) to safe path and use execlp
remove all system() calls
@@ -78,5 +76,8 @@ Doesn't really matter
d processsOptions errors
fix unknown times, maybe only output timeout
remove additional output under valgrind
+ readFile() bug where lines have ':' or '?' in them?!
+ x fix immediate bug
+ long term style solution
diff --git a/proxy.cpp b/proxy.cpp
index 9e2506a..08f4b8c 100755
--- a/proxy.cpp
+++ b/proxy.cpp
@@ -500,10 +500,7 @@ void test_execution::child_valgrind()
nums_pipe.close_write();
start_timeout();
- execl("/usr/bin/valgrind", "/usr/bin/valgrind", "--trace-children=yes", /*"--log-fd=-1",*/ "-q", "./proxy", test.name, NULL);
-
- // Execl failed
- EXIT_IF_ERROR(true, "valgrind execute failed");
+ exec("valgrind", "valgrind", "--trace-children=yes", /*"--log-fd=-1",*/ "-q", "./proxy", test.name, NULL);
}
--
GitLab